]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dsdb: Fix CID 1453465: Null pointer dereferences (NULL_RETURNS)
authorVolker Lendecke <vl@samba.org>
Tue, 3 Sep 2019 08:29:53 +0000 (10:29 +0200)
committerJeremy Allison <jra@samba.org>
Wed, 4 Sep 2019 17:03:33 +0000 (17:03 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/dsdb/samdb/ldb_modules/encrypted_secrets.c

index 0d46031ec64eadaafb3c1af9832767579bf0f8bf..7e6d4b160d479d56106d673283fcc316109a696f 100644 (file)
@@ -834,6 +834,14 @@ static const struct ldb_message *encrypt_secret_attributes(
                        struct ldb_message_element* enc = NULL;
                        if (encrypted_msg == NULL) {
                                encrypted_msg = ldb_msg_copy_shallow(ctx, msg);
+                               if (encrypted_msg == NULL) {
+                                       ldb_set_errstring(
+                                               ldb,
+                                               "Out of memory, allocating "
+                                               "ldb_message_element\n");
+                                       *err = LDB_ERR_OPERATIONS_ERROR;
+                                       return NULL;
+                               }
                                encrypted_msg->dn = msg->dn;
                        }
                        enc = encrypt_element(err,