]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Unitless breakpoints
authorJohan Beckers <33622049+johanlef@users.noreply.github.com>
Fri, 7 Sep 2018 11:12:04 +0000 (13:12 +0200)
committerXhmikosR <xhmikosr@gmail.com>
Sun, 21 Oct 2018 18:31:28 +0000 (21:31 +0300)
If I want to customise the breakpoints using `em`, I get compatibility errors.

It is good practice to set breakpoints in `em` instead of `px` when users use browser scaling.
See https://zellwk.com/blog/media-query-units/#concluding-the-experiments for more information why someone would like to do this. Only Safari users can get annoyed: https://adamwathan.me/dont-use-em-for-media-queries/

In any case, using a unitless number at line 42 would be very convenient.

scss/mixins/_breakpoints.scss

index 59f25a27e6e9b8bca8040b0579f2ddf6b20965f3..cfdb1976b35a918de28a65a4ba28e2518fb46f33 100644 (file)
@@ -39,7 +39,7 @@
 //    767.98px
 @function breakpoint-max($name, $breakpoints: $grid-breakpoints) {
   $next: breakpoint-next($name, $breakpoints);
-  @return if($next, breakpoint-min($next, $breakpoints) - .02px, null);
+  @return if($next, breakpoint-min($next, $breakpoints) - .02, null);
 }
 
 // Returns a blank string if smallest breakpoint, otherwise returns the name with a dash in front.