memory: tegra30-emc: Fix dll_change check

The code checking whether the specified memory timing enables DLL
in the EMRS register was reversed. DLL is enabled if bit A0 is low.
Fix the check.

Fixes: e34212c75a68 ("memory: tegra: Introduce Tegra30 EMC driver")
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Link: https://patch.msgid.link/20260126-fix-emc-dllchange-v1-2-47ad3bb63262@nvidia.com
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
index 606106dd2b32ef289f8374fb0ce3150caab3a1fc..5812c8cd6ce4fc120f676fd784149517f7b8c33c 100644 (file)
--- a/drivers/memory/tegra/tegra30-emc.c
+++ b/drivers/memory/tegra/tegra30-emc.c
@@ -554,14 +554,14 @@ static int emc_prepare_timing_change(struct tegra_emc *emc, unsigned long rate)
        emc->emc_cfg = readl_relaxed(emc->regs + EMC_CFG);
        emc_dbg = readl_relaxed(emc->regs + EMC_DBG);
 
-       if (emc->dll_on == !!(timing->emc_mode_1 & 0x1))
+       if (emc->dll_on == !(timing->emc_mode_1 & 0x1))
                dll_change = DLL_CHANGE_NONE;
-       else if (timing->emc_mode_1 & 0x1)
+       else if (!(timing->emc_mode_1 & 0x1))
                dll_change = DLL_CHANGE_ON;
        else
                dll_change = DLL_CHANGE_OFF;
 
-       emc->dll_on = !!(timing->emc_mode_1 & 0x1);
+       emc->dll_on = !(timing->emc_mode_1 & 0x1);
 
        if (timing->data[80] && !readl_relaxed(emc->regs + EMC_ZCAL_INTERVAL))
                emc->zcal_long = true;