Remove check-cocci from check-local target.

check-cocci is still a good idea -- perhaps as a cron job?  But
doing it as part of our regular tests has just been confusing,
especially to volunteers who shouldn't have to become coccinelle
experts in order to get their patches through our CI.

Closes #40030.

diff --git a/Makefile.am b/Makefile.am
index 8b55bf0e32523e1f3c0e434566ec63b018a4c10e..3b30c01f00bc59e95886928dd7a831f1a39d5bb1 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -271,8 +271,7 @@ check-local:                                        \
        check-spaces                            \
        check-changes                           \
        check-includes                          \
-       shellcheck                              \
-       check-cocci
+       shellcheck
 
 need-chutney-path:
        @if test ! -d "$$CHUTNEY_PATH"; then \

diff --git a/changes/ticket40030 b/changes/ticket40030
new file mode 100644 (file)
index 0000000..c5f3ca4
--- /dev/null
+++ b/changes/ticket40030
@@ -0,0 +1,7 @@
+  o Removed features:
+    - Our "check-local" test target no longer tries to use the Coccinelle
+      semantic patching tool parse all the C files.  While it is a good idea
+      to try to make sure Coccinelle works on our C before we run a
+      Coccinelle patch, doing so on every test run has proven to be disruptive.
+      You can still run this tool manually with "make check-cocci". Closes
+      ticket 40030.