]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Use name resolver 2.0 during pattern typechecking
authorOwen Avery <powerboat9.gamer@gmail.com>
Tue, 15 Oct 2024 19:35:21 +0000 (15:35 -0400)
committerP-E-P <32375388+P-E-P@users.noreply.github.com>
Wed, 16 Oct 2024 09:29:59 +0000 (09:29 +0000)
gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-pattern.cc: Add includes.
(TypeCheckPattern::visit): Use name resolver 2.0 if enabled.

* resolve/rust-name-resolution-context.cc
(NameResolutionContext::lookup): Make const qualified.
* resolve/rust-name-resolution-context.h
(NameResolutionContext::lookup): Likewise.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
gcc/rust/resolve/rust-name-resolution-context.cc
gcc/rust/resolve/rust-name-resolution-context.h
gcc/rust/typecheck/rust-hir-type-check-pattern.cc

index 28907dca6d22502da9ba412a05fb601bd29e9750..05c392df62c6a57a3ac7fb50ea3191a0c047b9f0 100644 (file)
@@ -92,7 +92,7 @@ NameResolutionContext::map_usage (Usage usage, Definition definition)
 }
 
 tl::optional<NodeId>
-NameResolutionContext::lookup (NodeId usage)
+NameResolutionContext::lookup (NodeId usage) const
 {
   auto it = resolved_nodes.find (Usage (usage));
 
index 34800baad91b891fa463a114439f7517ecb33d0b..13acef3c6205a2963e8d2ea5e10cf3a53c577797 100644 (file)
@@ -213,7 +213,7 @@ public:
   // TODO: Use newtype pattern for Usage and Definition
   void map_usage (Usage usage, Definition definition);
 
-  tl::optional<NodeId> lookup (NodeId usage);
+  tl::optional<NodeId> lookup (NodeId usage) const;
 
 private:
   /* Map of "usage" nodes which have been resolved to a "definition" node */
index 1265564b2ac92de4ec1deabe5fe968a6f3328183..e5859edca79e53bc390b94181ba5fd662fee3014 100644 (file)
 #include "rust-hir-pattern.h"
 #include "rust-hir-type-check-expr.h"
 #include "rust-type-util.h"
+#include "rust-immutable-name-resolution-context.h"
+
+// for flag_name_resolution_2_0
+#include "options.h"
 
 namespace Rust {
 namespace Resolver {
@@ -49,12 +53,26 @@ TypeCheckPattern::visit (HIR::PathInExpression &pattern)
 
   NodeId ref_node_id = UNKNOWN_NODEID;
   bool maybe_item = false;
-  maybe_item
-    |= resolver->lookup_resolved_name (pattern.get_mappings ().get_nodeid (),
-                                      &ref_node_id);
-  maybe_item
-    |= resolver->lookup_resolved_type (pattern.get_mappings ().get_nodeid (),
-                                      &ref_node_id);
+
+  if (flag_name_resolution_2_0)
+    {
+      auto &nr_ctx
+       = Resolver2_0::ImmutableNameResolutionContext::get ().resolver ();
+
+      if (auto id = nr_ctx.lookup (pattern.get_mappings ().get_nodeid ()))
+       {
+         ref_node_id = *id;
+         maybe_item = true;
+       }
+    }
+  else
+    {
+      maybe_item |= resolver->lookup_resolved_name (
+       pattern.get_mappings ().get_nodeid (), &ref_node_id);
+      maybe_item |= resolver->lookup_resolved_type (
+       pattern.get_mappings ().get_nodeid (), &ref_node_id);
+    }
+
   bool path_is_const_item = false;
 
   if (maybe_item)