]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: add WQ_PERCPU to alloc_workqueue users
authorMarco Crivellari <marco.crivellari@suse.com>
Mon, 2 Feb 2026 10:37:56 +0000 (11:37 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 3 Feb 2026 00:18:09 +0000 (19:18 -0500)
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.

In order to keep alloc_workqueue() behavior identical, explicitly request
WQ_PERCPU.

Link: https://lore.kernel.org/all/20250221112
Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patch.msgid.link/20260202103756.62138-3-marco.crivellari@suse.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_device.c
drivers/gpu/drm/xe/xe_ggtt.c
drivers/gpu/drm/xe/xe_hw_engine_group.c
drivers/gpu/drm/xe/xe_sriov.c

index 9cf82bde36c42052045ab1f501c1f9f66700fce1..9e5fb0d4b8e770d3e3d89c6704d2d03fa94f18fe 100644 (file)
@@ -508,8 +508,8 @@ struct xe_device *xe_device_create(struct pci_dev *pdev,
        xe->preempt_fence_wq = alloc_ordered_workqueue("xe-preempt-fence-wq",
                                                       WQ_MEM_RECLAIM);
        xe->ordered_wq = alloc_ordered_workqueue("xe-ordered-wq", 0);
-       xe->unordered_wq = alloc_workqueue("xe-unordered-wq", 0, 0);
-       xe->destroy_wq = alloc_workqueue("xe-destroy-wq", 0, 0);
+       xe->unordered_wq = alloc_workqueue("xe-unordered-wq", WQ_PERCPU, 0);
+       xe->destroy_wq = alloc_workqueue("xe-destroy-wq", WQ_PERCPU, 0);
        if (!xe->ordered_wq || !xe->unordered_wq ||
            !xe->preempt_fence_wq || !xe->destroy_wq) {
                /*
index 60665ad1415bebf51d41fb044d05f20cbffb7813..8b9d7c0bbe907190cf3cd7f8e4f26406d6c39d94 100644 (file)
@@ -367,7 +367,7 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
        else
                ggtt->pt_ops = &xelp_pt_ops;
 
-       ggtt->wq = alloc_workqueue("xe-ggtt-wq", WQ_MEM_RECLAIM, 0);
+       ggtt->wq = alloc_workqueue("xe-ggtt-wq", WQ_MEM_RECLAIM | WQ_PERCPU, 0);
        if (!ggtt->wq)
                return -ENOMEM;
 
index 2ef33dfbe3a2b113c848cae371f22fd12bea2835..4c2b113364d33789c116c7e564409bc575b76cf6 100644 (file)
@@ -51,7 +51,8 @@ hw_engine_group_alloc(struct xe_device *xe)
        if (!group)
                return ERR_PTR(-ENOMEM);
 
-       group->resume_wq = alloc_workqueue("xe-resume-lr-jobs-wq", 0, 0);
+       group->resume_wq = alloc_workqueue("xe-resume-lr-jobs-wq", WQ_PERCPU,
+                                          0);
        if (!group->resume_wq)
                return ERR_PTR(-ENOMEM);
 
index ea411944609b21aa07ab36df9e8fd9c9f18bfdcc..f3835867fce5d2fbbdb3b9035c7d79b2ef00fad0 100644 (file)
@@ -120,7 +120,7 @@ int xe_sriov_init(struct xe_device *xe)
                xe_sriov_vf_init_early(xe);
 
        xe_assert(xe, !xe->sriov.wq);
-       xe->sriov.wq = alloc_workqueue("xe-sriov-wq", 0, 0);
+       xe->sriov.wq = alloc_workqueue("xe-sriov-wq", WQ_PERCPU, 0);
        if (!xe->sriov.wq)
                return -ENOMEM;