[#1818] Addressed some cosmetic review comments

modified:
    src/hooks/dhcp/high_availability/tests/ha_mt_unittest.cc
    src/lib/config/cmd_http_listener.h
    src/lib/http/client.cc
    src/lib/http/client.h

diff --git a/src/hooks/dhcp/high_availability/tests/ha_mt_unittest.cc b/src/hooks/dhcp/high_availability/tests/ha_mt_unittest.cc
index f1f6836cb2ad19e962944795cd4817622dc59900..d6c046a1f7190c2ab67525ad313cfc81422f3f66 100644 (file)
--- a/src/hooks/dhcp/high_availability/tests/ha_mt_unittest.cc
+++ b/src/hooks/dhcp/high_availability/tests/ha_mt_unittest.cc
@@ -204,7 +204,7 @@ TEST_F(HAMtServiceTest, multiThreadingBasics) {
         ASSERT_TRUE(service->client_);
         ASSERT_TRUE(service->client_->isStopped());
 
-        // Listener should exist but not be stopped..
+        // Listener should exist but be stopped..
         ASSERT_TRUE(service->listener_);
         ASSERT_TRUE(service->client_->isStopped());
 

diff --git a/src/lib/config/cmd_http_listener.h b/src/lib/config/cmd_http_listener.h
index dbde66e03a450d5ce06de06d4f2a303b19352e63..0baacafbe6643c7d2dfd49c491cc6b70362591d9 100644 (file)
--- a/src/lib/config/cmd_http_listener.h
+++ b/src/lib/config/cmd_http_listener.h
@@ -41,10 +41,10 @@ public:
     /// @brief Starts running the listener's thread pool.
     void start();
 
-    /// @brief Pauses the listener's thread pool. 
+    /// @brief Pauses the listener's thread pool.
     void pause();
 
-    /// @brief Resumes running the listener's thread pool. 
+    /// @brief Resumes running the listener's thread pool.
     void resume();
 
     /// @brief Stops the listener's thread pool.
@@ -63,8 +63,8 @@ public:
 
     /// @brief Indicates if the thread pool is stopped.
     ///
-    /// @return True if the thread pool does not exist or it 
-    /// is in the STOPPED state, False otherwise.
+    /// @return True if the thread pool does not exist or it
+    /// is in the STOPPED state, false otherwise.
     bool isStopped();
 
     /// @brief Indicates if the thread pool processing is running.
@@ -106,7 +106,7 @@ public:
     }
 
     asiolink::IOServicePtr getThreadIOService() const {
-        return(thread_io_service_);
+        return (thread_io_service_);
     }
 
 private:

diff --git a/src/lib/http/client.cc b/src/lib/http/client.cc
index 777355dcc4780dac7681e5a475d3ce19489b2726..a2c9c68fa3a2aff57f16801d0687f68ed1f4e2b9 100644 (file)
--- a/src/lib/http/client.cc
+++ b/src/lib/http/client.cc
@@ -1827,7 +1827,7 @@ public:
         conn_pool_->closeAll();
     }
 
-    /// @brief Fetches the thread pool's operational state.
+    /// @brief Fetches the thread pool's run state.
     ///
     /// @return Operational state of the thread pool.
     HttpThreadPool::RunState getRunState() const {
@@ -1916,7 +1916,7 @@ private:
 };
 
 HttpClient::HttpClient(IOService& io_service, size_t thread_pool_size,
-                       bool defer_thread_start/* = false*/) {
+                       bool defer_thread_start /* = false */) {
     if (thread_pool_size > 0) {
         if (!MultiThreadingMgr::instance().getMode()) {
             isc_throw(InvalidOperation,

diff --git a/src/lib/http/client.h b/src/lib/http/client.h
index 5e7f51f24f3bed86a70524a20b19996a43c02016..a9aae459f3bfd9d5728c66f3bf3bb066c6807022 100644 (file)
--- a/src/lib/http/client.h
+++ b/src/lib/http/client.h
@@ -136,9 +136,8 @@ public:
     ///
     /// @param io_service IO service to be used by the HTTP client.
     /// @param thread_pool_size maximum number of threads in the thread pool.
-    /// @param defer_thread_start if true, then the thread pool will be
-    /// created but started  Applicable only when thread-pool-size is
-    /// greater than zero.
+    /// @param defer_thread_start if true, the thread pool will be created but
+    /// started. Applicable only when thread-pool-size is greater than zero.
     /// A value greater than zero enables multi-threaded mode and sets the
     /// maximum number of concurrent connections per URL.  A value of zero
     /// (default) enables single-threaded mode with one connection per URL.
@@ -305,7 +304,7 @@ public:
     /// @return the number of running threads.
     uint16_t getThreadCount() const;
 
-    /// @brief Fetches the thread pool's operational state.
+    /// @brief Fetches the thread pool's run state.
     ///
     /// @return Operational state of the thread pool.
     /// @throw InvalidOperation if the thread pool does not exist.