ext4: factor out ext4_get_maxbytes()

commit dbe27f06fa38b9bfc598f8864ae1c5d5831d9992 upstream.

There are several locations that get the correct maxbytes value based on
the inode's block type. It would be beneficial to extract a common
helper function to make the code more clear.

Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Baokun Li <libaokun1@huawei.com>
Link: https://patch.msgid.link/20250506012009.3896990-3-yi.zhang@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index fec021e6bb60091b316f28945fbd6b55706a3b2a..1dc1292d8977be7accdff13322de2f4a810f37b2 100644 (file)
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -3229,6 +3229,13 @@ static inline unsigned int ext4_flex_bg_size(struct ext4_sb_info *sbi)
        return 1 << sbi->s_log_groups_per_flex;
 }
 
+static inline loff_t ext4_get_maxbytes(struct inode *inode)
+{
+       if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
+               return inode->i_sb->s_maxbytes;
+       return EXT4_SB(inode->i_sb)->s_bitmap_maxbytes;
+}
+
 #define ext4_std_error(sb, errno)                              \
 do {                                                           \
        if ((errno))                                            \

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 3dc1caa504556c77e8a44ebe353adb5535b727e5..d659d7c36713398df3bc9849725c166e8fefd769 100644 (file)
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4970,12 +4970,7 @@ static const struct iomap_ops ext4_iomap_xattr_ops = {
 
 static int ext4_fiemap_check_ranges(struct inode *inode, u64 start, u64 *len)
 {
-       u64 maxbytes;
-
-       if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
-               maxbytes = inode->i_sb->s_maxbytes;
-       else
-               maxbytes = EXT4_SB(inode->i_sb)->s_bitmap_maxbytes;
+       u64 maxbytes = ext4_get_maxbytes(inode);
 
        if (*len == 0)
                return -EINVAL;

diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index c78df91f17da31af8883dc3f25289f60268a412e..bbed22731ac92ff55e8d77b4fc57ab1b29ac8f05 100644 (file)
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -858,12 +858,7 @@ static int ext4_file_open(struct inode *inode, struct file *filp)
 loff_t ext4_llseek(struct file *file, loff_t offset, int whence)
 {
        struct inode *inode = file->f_mapping->host;
-       loff_t maxbytes;
-
-       if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
-               maxbytes = EXT4_SB(inode->i_sb)->s_bitmap_maxbytes;
-       else
-               maxbytes = inode->i_sb->s_maxbytes;
+       loff_t maxbytes = ext4_get_maxbytes(inode);
 
        switch (whence) {
        default: