rndis_wlan: harmless issue calling set_bit()

commit e3958e9d60b4570fff709f397ef5c6b8483f40f7 upstream.

These are used like:

	set_bit(WORK_LINK_UP, &priv->work_pending);

The problem is that set_bit() takes the actual bit number and not a mask
so static checkers get upset.  It doesn't affect run time because we do
it consistently, but we may as well clean it up.

Fixes: 6010ce07a66c ('rndis_wlan: do link-down state change in worker thread')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index d2a9a08210be1379b4e56ad266c1695ca6486d17..19a1c9cde772bd045598e40c9822225ba69c9383 100644 (file)
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -356,9 +356,9 @@ struct ndis_80211_pmkid {
 #define CAP_MODE_80211G                4
 #define CAP_MODE_MASK          7
 
-#define WORK_LINK_UP           (1<<0)
-#define WORK_LINK_DOWN         (1<<1)
-#define WORK_SET_MULTICAST_LIST        (1<<2)
+#define WORK_LINK_UP           0
+#define WORK_LINK_DOWN         1
+#define WORK_SET_MULTICAST_LIST        2
 
 #define RNDIS_WLAN_ALG_NONE    0
 #define RNDIS_WLAN_ALG_WEP     (1<<0)