]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfsd: update create verifier comment
authorJ. Bruce Fields <bfields@redhat.com>
Mon, 19 Feb 2024 16:44:28 +0000 (11:44 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:18:54 +0000 (16:18 +0200)
[ Upstream commit 2336d696862186fd4a6ddd1ea0cb243b3e32847c ]

I don't know if that Solaris behavior matters any more or if it's still
possible to look up that bug ID any more.  The XFS behavior's definitely
still relevant, though; any but the most recent XFS filesystems will
lose the top bits.

Reported-by: Frank S. Filz <ffilzlnx@mindspring.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/vfs.c

index 24a5b5cfcfb0323744fdc579c1c1714d3919ca61..59e30cff920cad07a5ebedaaf2f938a408cd3257 100644 (file)
@@ -1436,7 +1436,8 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp,
 
        if (nfsd_create_is_exclusive(createmode)) {
                /* solaris7 gets confused (bugid 4218508) if these have
-                * the high bit set, so just clear the high bits. If this is
+                * the high bit set, as do xfs filesystems without the
+                * "bigtime" feature.  So just clear the high bits. If this is
                 * ever changed to use different attrs for storing the
                 * verifier, then do_open_lookup() will also need to be fixed
                 * accordingly.