]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
socket: Fix internal_select()
authorVictor Stinner <victor.stinner@gmail.com>
Fri, 22 Jul 2016 15:26:53 +0000 (17:26 +0200)
committerVictor Stinner <victor.stinner@gmail.com>
Fri, 22 Jul 2016 15:26:53 +0000 (17:26 +0200)
Bug found by Pavel Belikov ("Fragment N1"):
http://www.viva64.com/en/b/0414/#ID0ECDAE

Modules/socketmodule.c

index 8f571a2eb4b57921d0be8a9216f1c48143750765..8e804af58c204f1c2be8c88999f313a36daee332 100644 (file)
@@ -648,7 +648,7 @@ internal_select(PySocketSockObject *s, int writing, _PyTime_t interval,
     assert(!(connect && !writing));
 
     /* Guard against closed socket */
-    if (s->sock_fd < 0)
+    if (s->sock_fd == INVALID_SOCKET)
         return 0;
 
     /* Prefer poll, if available, since you can poll() any fd