]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
coredump: fix filename in journal when not compressed
authorxdavidwu <xdavidwuph@gmail.com>
Fri, 5 Nov 2021 14:37:06 +0000 (22:37 +0800)
committerLuca Boccassi <luca.boccassi@gmail.com>
Fri, 5 Nov 2021 22:47:16 +0000 (22:47 +0000)
Since 587f2a5e564cf434c2e0a653f52b8f73e86092d8, filename for
not-compressed coredump is missing from save_external_coredump, making
it write COREDUMP_FILENAME= (empty) in journal, making `coredumpctl`
report it missing but it is actually saved.
This fixes it.

src/coredump/coredump.c

index d7eab3d36c7499b66138d9c8f12295f4439fdf72..a88f4955715d6d862edd5c9c335f948fbf84c849 100644 (file)
@@ -525,6 +525,7 @@ static int save_external_coredump(
         if (lseek(fd, 0, SEEK_SET) == (off_t) -1)
                 return log_error_errno(errno, "Failed to seek on coredump %s: %m", fn);
 
+        *ret_filename = TAKE_PTR(fn);
         *ret_data_fd = TAKE_FD(fd);
         *ret_size = (uint64_t) st.st_size;
         *ret_truncated = truncated;