]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
RISC-V: Don't make Ztso imply A
authorPalmer Dabbelt <palmer@rivosinc.com>
Wed, 13 Dec 2023 03:54:05 +0000 (19:54 -0800)
committerPatrick O'Neill <patrick@rivosinc.com>
Thu, 25 Jan 2024 00:37:15 +0000 (16:37 -0800)
I can't actually find anything in the ISA manual that makes Ztso imply
A.  In theory the memory ordering is just a different thing that the set
of availiable instructions (ie, Ztso without A would still imply TSO for
loads and stores).  It also seems like a configuration that could be
sane to build: without A it's all but impossible to write any meaningful
multi-core code, and TSO is really cheap for a single core.

That said, I think it's kind of reasonable to provide A to users asking
for Ztso.  So maybe even if this was a mistake it's the right thing to
do?

gcc/ChangeLog:

* common/config/riscv/riscv-common.cc (riscv_implied_info):
Remove {"ztso", "a"}.

gcc/common/config/riscv/riscv-common.cc

index 4da7f37303b20c0754373c5c63a343b8da79ecc5..0a3c5cdfae5bb8108b502ded7c450a195e865648 100644 (file)
@@ -96,8 +96,6 @@ static const riscv_implied_info_t riscv_implied_info[] =
   {"zks", "zksed"},
   {"zks", "zksh"},
 
-  {"ztso", "a"},
-
   {"v", "zvl128b"},
   {"v", "zve64d"},