printf-hook: Avoid double-free when freeing Vstr config

Thread-specific objects get freed when the thread value object is
destroyed (wasn't the case earlier, i.e. before 2b19dd35), which
may cause the second call to vstr_free_conf() to fail in an assert
in Vstr (depending on how it was built).

diff --git a/src/libstrongswan/utils/printf_hook.c b/src/libstrongswan/utils/printf_hook.c
index 6e51aa4c3eb22e36d1e7af486a2822425e5ad5f3..f030f45c8db3dc71f3e9bb9e62091e448b684d75 100644 (file)
--- a/src/libstrongswan/utils/printf_hook.c
+++ b/src/libstrongswan/utils/printf_hook.c
@@ -474,7 +474,6 @@ METHOD(printf_hook_t, destroy, void,
        /* freeing the Vstr_conf of the main thread */
        vstr_conf->destroy(vstr_conf);
        vstr_conf = NULL;
-       vstr_free_conf(conf);
        vstr_exit();
 #endif
        free(this);