]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Revert "rtc: cpcap: Fix initial enable_irq/disable_irq balance"
authorJon Hunter <jonathanh@nvidia.com>
Fri, 31 Oct 2025 10:37:41 +0000 (10:37 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 31 Oct 2025 11:42:23 +0000 (12:42 +0100)
Commit e0762fd26ad6 ("rtc: cpcap: Fix initial enable_irq/disable_irq
balance") set 'alarm_enabled' prior to calling the function
devm_request_threaded_irq() because this enables the IRQ. However, right
after calling devm_request_threaded_irq(), the driver calls
disable_irq() to disable the IRQ and so now 'alarm_enabled' will be true
but the IRQ is actually disabled. Revert this commit to fix the
'alarm_enabled' state.

Fixes: e0762fd26ad6 ("rtc: cpcap: Fix initial enable_irq/disable_irq balance")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://patch.msgid.link/20251031103741.945460-2-jonathanh@nvidia.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-cpcap.c

index 8b6b35716f539e94cf6270c73efae12c86bd2189..c170345ac076ca540231c23cec75af10214f9660 100644 (file)
@@ -268,7 +268,6 @@ static int cpcap_rtc_probe(struct platform_device *pdev)
                return err;
 
        rtc->alarm_irq = platform_get_irq(pdev, 0);
-       rtc->alarm_enabled = true;
        err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL,
                                        cpcap_rtc_alarm_irq,
                                        IRQF_TRIGGER_NONE | IRQF_ONESHOT,