]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/rockchip: analogix_dp: Apply devm_clk_get_optional() for &rockchip_dp_device...
authorDamon Ding <damon.ding@rock-chips.com>
Sun, 28 Sep 2025 10:37:34 +0000 (18:37 +0800)
committerHeiko Stuebner <heiko@sntech.de>
Tue, 14 Oct 2025 12:12:23 +0000 (14:12 +0200)
The "grf" clock is optional for Rockchip eDP controller(RK3399 needs
while RK3288 and RK3588 do not).

It can make the code more concise to use devm_clk_get_optional()
instead of devm_clk_get() with extra checks.

In addtion, DRM_DEV_ERROR() is replaced by dev_err_probe().

Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250928103734.4007257-1-damon.ding@rock-chips.com
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c

index d30f0983a53a6daa9abb26a78ffb81f91c9501bd..937f83cf42fc76d19ceab85ebb139329059f7376 100644 (file)
@@ -335,15 +335,9 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
                return PTR_ERR(dp->grf);
        }
 
-       dp->grfclk = devm_clk_get(dev, "grf");
-       if (PTR_ERR(dp->grfclk) == -ENOENT) {
-               dp->grfclk = NULL;
-       } else if (PTR_ERR(dp->grfclk) == -EPROBE_DEFER) {
-               return -EPROBE_DEFER;
-       } else if (IS_ERR(dp->grfclk)) {
-               DRM_DEV_ERROR(dev, "failed to get grf clock\n");
-               return PTR_ERR(dp->grfclk);
-       }
+       dp->grfclk = devm_clk_get_optional(dev, "grf");
+       if (IS_ERR(dp->grfclk))
+               return dev_err_probe(dev, PTR_ERR(dp->grfclk), "failed to get grf clock\n");
 
        dp->pclk = devm_clk_get(dev, "pclk");
        if (IS_ERR(dp->pclk)) {