]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Check return code of BIO_ADDR_rawaddress
authorNorbert Pocs <norbertp@openssl.org>
Sun, 5 Oct 2025 07:39:22 +0000 (09:39 +0200)
committerNeil Horman <nhorman@openssl.org>
Tue, 7 Oct 2025 16:36:13 +0000 (12:36 -0400)
Fixes coverity issue: https://scan5.scan.coverity.com/#/project-view/64471/10222?selectedIssue=1666584
Thank you for the report!

Signed-off-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/28751)

(cherry picked from commit 7fb9163586234ed9eecf95ae2fd7185a9dcb556e)

apps/lib/s_cb.c

index e94c5d6121459451081b2791415cc502c8b9bd5e..67a6fbf3e26102417e54f3bf406db6ce313d646c 100644 (file)
@@ -873,7 +873,8 @@ int generate_stateless_cookie_callback(SSL *ssl, unsigned char *cookie,
     buffer = app_malloc(length, "cookie generate buffer");
 
     memcpy(buffer, &port, sizeof(port));
-    BIO_ADDR_rawaddress(peer, buffer + sizeof(port), NULL);
+    if (!BIO_ADDR_rawaddress(peer, buffer + sizeof(port), NULL))
+        goto end;
 
     if (EVP_Q_mac(NULL, "HMAC", NULL, "SHA1", NULL,
                   cookie_secret, COOKIE_SECRET_LENGTH, buffer, length,