]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdb/testsuite: use "is" for type comparison in Python files
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 29 Oct 2025 17:49:18 +0000 (13:49 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Thu, 30 Oct 2025 16:15:13 +0000 (12:15 -0400)
Fix flake8 warnings like:

    gdb/testsuite/gdb.python/py-unwind.py:253:20: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`

Change-Id: I506c0874bba88aa418757d94168992bf4ec677f8
Approved-By: Tom Tromey <tom@tromey.com>
gdb/testsuite/gdb.python/py-missing-objfile.py
gdb/testsuite/gdb.python/py-unwind.py
gdb/testsuite/gdb.python/source2.py

index bdd7a599b636db5e426029f7b86324f8e076f895..dab34168530bb6e6227bf967bd922c16f8e6e922 100644 (file)
@@ -41,10 +41,10 @@ handler_last_filename = None
 # A helper function that makes some assertions about the arguments
 # passed to a MissingObjfileHandler.__call__() method.
 def check_args(pspace, buildid, filename):
-    assert type(filename) == str
+    assert type(filename) is str
     assert filename != ""
-    assert type(pspace) == gdb.Progspace
-    assert type(buildid) == str
+    assert type(pspace) is gdb.Progspace
+    assert type(buildid) is str
     assert buildid != ""
 
 
index 183c6b1eb67c5895a2111c9e9f336917c6413706..50c6d55cac0547bbaeecff5c28c4f11967f7de8a 100644 (file)
@@ -250,7 +250,7 @@ class validating_unwinder(Unwinder):
 
         for key, value in info.items():
             assert key in old_info, key + " not in old_info"
-            assert type(value) == type(old_info[key])
+            assert type(value) is type(old_info[key])
             if isinstance(value, gdb.Block):
                 assert value.start == old_info[key].start
                 assert value.end == old_info[key].end
index 7ca0bb2fe9896ef9604f428519b502ff48b80f0b..59ac6f6a6b39571fcff918a2d2d3c00659fa9820 100644 (file)
@@ -16,6 +16,6 @@
 #  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 # Make sure __file__ is defined.
-assert type(__file__) == str
+assert type(__file__) is str
 
 print("y%ss" % "e")