drm/amd/pm: remove unnecessary prints for smu busy

smu busy is a normal case when calling SMU_MSG_GetBadPageCount, so no need
to print error status at each time.Instead, only print error status when
timeout given by user is reached.

Signed-off-by: Gangliang Xie <ganglxie@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
index 0ce8cff27bf9474d0af1225366d34d0edc56a904..fc580800609c0aa330bff584da1279baadc61b68 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c
@@ -956,6 +956,8 @@ static int smu_v13_0_12_get_badpage_count(struct amdgpu_device *adev, uint32_t *
                now = (uint64_t)ktime_to_ms(ktime_get());
        } while (now < end);
 
+       dev_err(adev->dev,
+                        "smu get bad page count timeout!\n");
        return ret;
 }
 

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 3b98065dac1d69c3af5871ea3ae2568ccadcb793..4040ff926544fb69338540ef888c8c390c685c00 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -164,9 +164,13 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
                                    msg_index, param, message);
                break;
        case SMU_RESP_BUSY_OTHER:
-               dev_err_ratelimited(adev->dev,
-                                   "SMU: I'm very busy for your command: index:%d param:0x%08X message:%s",
-                                   msg_index, param, message);
+               /* It is normal for SMU_MSG_GetBadPageCount to return busy
+                * so don't print error at this case.
+                */
+               if (msg != SMU_MSG_GetBadPageCount)
+                       dev_err_ratelimited(adev->dev,
+                                               "SMU: I'm very busy for your command: index:%d param:0x%08X message:%s",
+                                               msg_index, param, message);
                break;
        case SMU_RESP_DEBUG_END:
                dev_err_ratelimited(adev->dev,