conf: Convert virDomainDefParseBootXML() to virXMLProp*()

After previous cleanups, the virDomainDefParseBootXML() function
uses a mixture of virXMLProp*() and the old virXMLPropString() +
virXXXTypeFromString() patterns. Rework it so that virXMLProp*()
is used.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 42eecd4f5035b2dd6167da77b3bd01c64d2208d4..d41cbc37b49d98fa70c3eaad26f48a06b0432a93 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -16905,7 +16905,6 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt,
     xmlNodePtr node;
     size_t i;
     int n;
-    g_autofree char *tmp = NULL;
     g_autofree xmlNodePtr *nodes = NULL;
 
     /* analysis of the boot devices */
@@ -16913,20 +16912,13 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt,
         return -1;
 
     for (i = 0; i < n && i < VIR_DOMAIN_BOOT_LAST; i++) {
-        int val;
-        g_autofree char *dev = virXMLPropString(nodes[i], "dev");
-        if (!dev) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           "%s", _("missing boot device"));
-            return -1;
-        }
-        if ((val = virDomainBootTypeFromString(dev)) < 0) {
-            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                           _("unknown boot device '%s'"),
-                           dev);
+        if (virXMLPropEnum(nodes[i], "dev",
+                           virDomainBootTypeFromString,
+                           VIR_XML_PROP_REQUIRED,
+                           &def->os.bootDevs[def->os.nBootDevs]) < 0)
             return -1;
-        }
-        def->os.bootDevs[def->os.nBootDevs++] = val;
+
+        def->os.nBootDevs++;
     }
 
     if ((node = virXPathNode("./os/bootmenu[1]", ctxt))) {
@@ -16935,36 +16927,33 @@ virDomainDefParseBootXML(xmlXPathContextPtr ctxt,
                                    &def->os.bootmenu) < 0)
             return -1;
 
-        tmp = virXMLPropString(node, "timeout");
-        if (tmp && def->os.bootmenu == VIR_TRISTATE_BOOL_YES) {
-            if (virStrToLong_uip(tmp, NULL, 0, &def->os.bm_timeout) < 0) {
-                virReportError(VIR_ERR_XML_ERROR, "%s",
-                               _("invalid value for boot menu timeout"));
+        if (def->os.bootmenu == VIR_TRISTATE_BOOL_YES) {
+            int rv;
+
+            if ((rv = virXMLPropUInt(node, "timeout", 10,
+                                     VIR_XML_PROP_NONE,
+                                     &def->os.bm_timeout)) < 0) {
                 return -1;
+            } else if (rv > 0) {
+                def->os.bm_timeout_set = true;
             }
-            def->os.bm_timeout_set = true;
         }
-        VIR_FREE(tmp);
     }
 
     if ((node = virXPathNode("./os/bios[1]", ctxt))) {
-        tmp = virXMLPropString(node, "useserial");
-        if (tmp) {
-            bool state = false;
-            ignore_value(virStringParseYesNo(tmp, &state));
-            def->os.bios.useserial = virTristateBoolFromBool(state);
-            VIR_FREE(tmp);
-        }
+        int rv;
 
-        tmp = virXMLPropString(node, "rebootTimeout");
-        if (tmp) {
-            /* that was really just for the check if it is there */
+        if (virXMLPropTristateBool(node, "useserial",
+                                   VIR_XML_PROP_NONE,
+                                   &def->os.bios.useserial) < 0) {
+            def->os.bios.useserial = VIR_TRISTATE_BOOL_NO;
+        }
 
-            if (virStrToLong_i(tmp, NULL, 0, &def->os.bios.rt_delay) < 0) {
-                virReportError(VIR_ERR_XML_ERROR, "%s",
-                               _("invalid value for rebootTimeout"));
-                return -1;
-            }
+        if ((rv = virXMLPropInt(node, "rebootTimeout", 10,
+                                VIR_XML_PROP_NONE,
+                                &def->os.bios.rt_delay, 0)) < 0) {
+            return -1;
+        } else if (rv > 0) {
             def->os.bios.rt_set = true;
         }
     }

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index c2c263dfabab0e530e9f482948908a25da4de1f5..584e15b6c7b0dd1ffcf575f1b5d92eada688cff2 100644 (file)
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2195,7 +2195,7 @@ typedef enum {
 VIR_ENUM_DECL(virDomainLockFailure);
 
 struct _virDomainBIOSDef {
-    int useserial; /* enum virTristateBool */
+    virTristateBool useserial;
     /* reboot-timeout parameters */
     bool rt_set;
     int rt_delay;
@@ -2324,7 +2324,7 @@ struct _virDomainOSDef {
     virArch arch;
     char *machine;
     size_t nBootDevs;
-    int bootDevs[VIR_DOMAIN_BOOT_LAST];
+    virDomainBootOrder bootDevs[VIR_DOMAIN_BOOT_LAST];
     virTristateBool bootmenu;
     unsigned int bm_timeout;
     bool bm_timeout_set;

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 1ac6253ad746e31e6c8e058c021c4cfeb6f0507a..561171126c4e62c8e9d2c33c06a6e0f293b24d1f 100644 (file)
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -609,6 +609,8 @@ libxlMakeDomBuildInfo(virDomainDef *def,
                 case VIR_DOMAIN_BOOT_NET:
                     bootorder[i] = 'n';
                     break;
+                case VIR_DOMAIN_BOOT_LAST:
+                    break;
             }
         }
         if (def->os.nBootDevs == 0) {

diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c
index 799fe05cbdba9cc0230a4213d23c22e752cd7829..87194ccbd1123529fb4bf0e57c70ab705daa29c1 100644 (file)
--- a/src/libxl/xen_xl.c
+++ b/src/libxl/xen_xl.c
@@ -1153,6 +1153,8 @@ xenFormatXLOS(virConf *conf, virDomainDef *def)
             default:
                 boot[i] = 'c';
                 break;
+            case VIR_DOMAIN_BOOT_LAST:
+                break;
             }
         }
 

diff --git a/src/libxl/xen_xm.c b/src/libxl/xen_xm.c
index 2e636d874ed0d6a55f5954ff31e61499cf9e0081..a962da9cad95ace9bebdb8c1cada2d03cf81f387 100644 (file)
--- a/src/libxl/xen_xm.c
+++ b/src/libxl/xen_xm.c
@@ -457,6 +457,8 @@ xenFormatXMOS(virConf *conf, virDomainDef *def)
             default:
                 boot[i] = 'c';
                 break;
+            case VIR_DOMAIN_BOOT_LAST:
+                break;
             }
         }
 

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 7ff4dc1835e418020f8a715fb77330e1199c063b..336f0bab2e7a6efdeb80801246c6e1e507109f53 100644 (file)
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -6183,7 +6183,7 @@ qemuProcessPrepareDeviceBootorder(virDomainDef *def)
         return;
 
     for (i = 0; i < def->os.nBootDevs; i++) {
-        switch ((virDomainBootOrder) def->os.bootDevs[i]) {
+        switch (def->os.bootDevs[i]) {
         case VIR_DOMAIN_BOOT_CDROM:
             bootCD = i + 1;
             break;

diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 94c6cd5c7a207428ecfa500144a31f3cc8b4252f..ccfd3e9d55974b430f98ec96ad3b4ab6b6a9d4d8 100644 (file)
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -3799,7 +3799,7 @@ prlsdkSetBootOrderVm(PRL_HANDLE sdkdom, virDomainDef *def)
     for (i = 0; i < def->os.nBootDevs; ++i) {
         virType = def->os.bootDevs[i];
 
-        switch ((int)virType) {
+        switch (virType) {
         case VIR_DOMAIN_BOOT_CDROM:
             sdkType = PDE_OPTICAL_DISK;
             break;
@@ -3809,6 +3809,8 @@ prlsdkSetBootOrderVm(PRL_HANDLE sdkdom, virDomainDef *def)
         case VIR_DOMAIN_BOOT_NET:
             sdkType = PDE_GENERIC_NETWORK_ADAPTER;
             break;
+        case VIR_DOMAIN_BOOT_FLOPPY:
+        case VIR_DOMAIN_BOOT_LAST:
         default:
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("Unsupported boot device type: '%s'"),