]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
netcmd: silo member add and remove should not set assigned_silo
authorRob van der Linde <rob@catalyst.net.nz>
Mon, 30 Oct 2023 23:27:56 +0000 (12:27 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 15 Nov 2023 04:05:34 +0000 (04:05 +0000)
The Windows tools don't do this either

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/netcmd/domain/auth/silo_member.py

index 638ad59b8ca3c91825232cdc0e1a9cf9832745ad..4094ba768406d94c950dfd7ee763e8c994744b28 100644 (file)
@@ -69,13 +69,9 @@ class cmd_domain_auth_silo_member_add(Command):
         if user is None:
             raise CommandError(f"User '{member}' not found.")
 
-        # Set the assigned silo.
-        user.assigned_silo = silo.dn
-
-        # Add member and save user.
+        # Add member.
         try:
             silo.add_member(ldb, user)
-            user.save(ldb)
         except ModelError as e:
             raise CommandError(e)
 
@@ -172,13 +168,9 @@ class cmd_domain_auth_silo_member_remove(Command):
         if user is None:
             raise CommandError(f"User '{member}' not found.")
 
-        # Unset the assigned silo.
-        user.assigned_silo = None
-
-        # Remove member and save user.
+        # Remove member.
         try:
             silo.remove_member(ldb, user)
-            user.save(ldb)
         except ModelError as e:
             raise CommandError(e)