]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
HID: sony: remove unneeded WARN_ON() in sony_leds_init()
authorRosalie Wanders <rosalie@mailbox.org>
Sat, 11 Apr 2026 15:32:48 +0000 (17:32 +0200)
committerJiri Kosina <jkosina@suse.com>
Tue, 28 Apr 2026 16:25:41 +0000 (18:25 +0200)
This commit removes the unneeded WARN_ON() macro usage in
sony_leds_init(), this is unneeded because the sony_leds_init() function
call is already gated behind a SONY_LED_SUPPORT check in
sony_input_configured()

Signed-off-by: Rosalie Wanders <rosalie@mailbox.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-sony.c

index 23db406092ef151da56dc8b6ec1d6530e2c8bae8..6a860b9ef677a281b3ceb4f702671bc1d0ab5844 100644 (file)
@@ -1640,9 +1640,6 @@ static int sony_leds_init(struct sony_sc *sc)
        u8 max_brightness[MAX_LEDS] = { [0 ... (MAX_LEDS - 1)] = 1 };
        u8 use_hw_blink[MAX_LEDS] = { 0 };
 
-       if (WARN_ON(!(sc->quirks & SONY_LED_SUPPORT)))
-               return -EINVAL;
-
        if (sc->quirks & BUZZ_CONTROLLER) {
                sc->led_count = 4;
                use_color_names = 0;