Bug 2518: assertion failed: comm.cc:1519: "F->flags.open"

Not seen in a while. I suspect its hiding behind a fixed F->closing()
test, so the whole if test may be obsolete.

Applying in order to close the bug with surety and sync the conditions on
shutdown and restart-closing.

diff --git a/src/comm.cc b/src/comm.cc
index 4e5caef1cce375ab7f97a005227baf59405636b6..d0529ba5d03eb5c769efca2c779a825ad5395463 100644 (file)
--- a/src/comm.cc
+++ b/src/comm.cc
@@ -1548,7 +1548,8 @@ _comm_close(int fd, char const *file, int line)
     if (F->closing())
         return;
 
-    if (shutting_down && (!F->flags.open || F->type == FD_FILE))
+    /* XXX: is this obsolete behind F->closing() ? */
+    if ( (shutting_down || reconfiguring) && (!F->flags.open || F->type == FD_FILE))
         return;
 
     /* The following fails because ipc.c is doing calls to pipe() to create sockets! */