Issue #22435: Fix a file descriptor leak when SocketServer bind fails.

diff --git a/Lib/socketserver.py b/Lib/socketserver.py
index 2f395fac242e7923e8abece3ea9cbe93680280eb..73399115b6a89d4a0cc4a053f1fbfabcbbbc47ab 100644 (file)
--- a/Lib/socketserver.py
+++ b/Lib/socketserver.py
@@ -426,8 +426,12 @@ class TCPServer(BaseServer):
         self.socket = socket.socket(self.address_family,
                                     self.socket_type)
         if bind_and_activate:
-            self.server_bind()
-            self.server_activate()
+            try:
+                self.server_bind()
+                self.server_activate()
+            except:
+                self.server_close()
+                raise
 
     def server_bind(self):
         """Called by constructor to bind the socket.

diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py
index 0617b30a69e784a80210c876c5f2217812e973a7..0276f993f97bd4370fef65e9883f03c1473ae3dd 100644 (file)
--- a/Lib/test/test_socketserver.py
+++ b/Lib/test/test_socketserver.py
@@ -302,6 +302,16 @@ class SocketServerTest(unittest.TestCase):
             t.join()
             s.server_close()
 
+    def test_tcpserver_bind_leak(self):
+        # Issue #22435: the server socket wouldn't be closed if bind()/listen()
+        # failed.
+        # Create many servers for which bind() will fail, to see if this result
+        # in FD exhaustion.
+        for i in range(1024):
+            with self.assertRaises(OverflowError):
+                socketserver.TCPServer((HOST, -1),
+                                       socketserver.StreamRequestHandler)
+
 
 def test_main():
     if imp.lock_held():

diff --git a/Misc/NEWS b/Misc/NEWS
index ab5a4cb3789a5c20650fa01b652b34584e6e1168..e5030cd5d81b8da4bd0dabfc320a1dd646682cbc 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -27,6 +27,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #22435: Fix a file descriptor leak when SocketServer bind fails.
+
 - Issue #13096: Fixed segfault in CTypes POINTER handling of large
   values.