]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
uprobes: Use kzalloc to allocate xol area
authorSven Schnelle <svens@linux.ibm.com>
Tue, 3 Sep 2024 10:23:12 +0000 (12:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2024 09:06:50 +0000 (11:06 +0200)
commit e240b0fde52f33670d1336697c22d90a4fe33c84 upstream.

To prevent unitialized members, use kzalloc to allocate
the xol area.

Fixes: b059a453b1cf1 ("x86/vdso: Add mremap hook to vm_special_mapping")
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20240903102313.3402529-1-svens@linux.ibm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/events/uprobes.c

index 826a2355da1ed13cee9a14433c83c79afb13b6cb..e91d6aac9855cc0eaf01c1ee38cfb9c5c3d98605 100644 (file)
@@ -1485,7 +1485,7 @@ static struct xol_area *__create_xol_area(unsigned long vaddr)
        uprobe_opcode_t insn = UPROBE_SWBP_INSN;
        struct xol_area *area;
 
-       area = kmalloc(sizeof(*area), GFP_KERNEL);
+       area = kzalloc(sizeof(*area), GFP_KERNEL);
        if (unlikely(!area))
                goto out;
 
@@ -1495,7 +1495,6 @@ static struct xol_area *__create_xol_area(unsigned long vaddr)
                goto free_area;
 
        area->xol_mapping.name = "[uprobes]";
-       area->xol_mapping.fault = NULL;
        area->xol_mapping.pages = area->pages;
        area->pages[0] = alloc_page(GFP_HIGHUSER);
        if (!area->pages[0])