]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/smbd: Remove unecessary 'else' block
authorNoel Power <noel.power@suse.com>
Thu, 10 Jun 2021 13:11:03 +0000 (14:11 +0100)
committerNoel Power <npower@samba.org>
Fri, 11 Jun 2021 09:30:53 +0000 (09:30 +0000)
This is an inconsequential cosmetic change, it just caught my eye
as looking a bit out of place compared to the surrounding code style.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/open.c

index 101757666fe5190dd21b3c8d797f34ff04039f3c..785a445e5cf261753f707d4123342afba33fb40c 100644 (file)
@@ -3613,9 +3613,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                                         smb_fname_str_dbg(smb_fname)));
                                if (S_ISDIR(smb_fname->st.st_ex_mode)) {
                                        return NT_STATUS_FILE_IS_A_DIRECTORY;
-                               } else {
-                                       return NT_STATUS_OBJECT_NAME_COLLISION;
                                }
+                               return NT_STATUS_OBJECT_NAME_COLLISION;
                        }
                        break;