]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
datamodel: logging: dnstap: changed log-* defaults to false
authorAleš Mrázek <ales.mrazek@nic.cz>
Fri, 6 Jun 2025 11:01:21 +0000 (13:01 +0200)
committerAleš Mrázek <ales.mrazek@nic.cz>
Fri, 31 Oct 2025 14:11:38 +0000 (15:11 +0100)
NEWS
doc/_static/config.schema.json
doc/user/config-logging-dnstap.rst
python/knot_resolver/datamodel/logging_schema.py

diff --git a/NEWS b/NEWS
index 150c3e2c4e559dcf44824867e8fdf1f5ae85cd26..44b0a8fa4332a29fb3719dd5a36a94853e823bb2 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -35,6 +35,10 @@ https://www.knot-resolver.cz/documentation/v6.0.16/upgrading.html
   - /network/proxy_protocol -> /network/proxy_protocol/enable
   - /network/tls/files-watchdog -> /network/tls/watchdog
   - /rate-limiting -> /rate-limiting/enable
+- Changed default values in declarative configuration model (YAML). (!1672)
+  - /logging/dnstap/log-queries: true -> false
+  - /logging/dnstap/log-responses: true -> false
+  - /logging/dnstap/log-tcp-rtt: true -> false
 
 
 Knot Resolver 6.0.16 (2025-10-30)
index 5200eadd4614c9ee9ddf9c02af92145d0e52e450..5c603965a904e9d460bda4d5be97cfc7835718d6 100644 (file)
                         "log-queries": {
                             "type": "boolean",
                             "description": "Log queries from downstream in wire format.",
-                            "default": true
+                            "default": false
                         },
                         "log-responses": {
                             "type": "boolean",
                             "description": "Log responses to downstream in wire format.",
-                            "default": true
+                            "default": false
                         },
                         "log-tcp-rtt": {
                             "type": "boolean",
                             "description": "Log TCP RTT (Round-trip time).",
-                            "default": true
+                            "default": false
                         }
                     },
                     "default": {
                         "enable": false,
                         "unix_socket": null,
-                        "log_queries": true,
-                        "log_responses": true,
-                        "log_tcp_rtt": true
+                        "log_queries": false,
+                        "log_responses": false,
+                        "log_tcp_rtt": false
                     }
                 }
             },
                 "dnstap": {
                     "enable": false,
                     "unix_socket": null,
-                    "log_queries": true,
-                    "log_responses": true,
-                    "log_tcp_rtt": true
+                    "log_queries": false,
+                    "log_responses": false,
+                    "log_tcp_rtt": false
                 }
             }
         },
index c9de7bea3060dda63bf9faf5c850d99be19acdf4..e783a2dbe42c15ad64e55c5392d36929756ef29f 100644 (file)
@@ -31,6 +31,6 @@ Tunables:
       dnstap:
         enable: true
         unix-socket: /tmp/dnstap.sock
-        # by default log is enabled for all
+        # by default log is disabled for all
         log-queries: true
         log-responses: true
index b6587584bc6c28ef7ec6e527957675973475f795..d0e6101250b526de5b6f2775f8bcfebf19359c5f 100644 (file)
@@ -77,9 +77,9 @@ class DnstapSchema(ConfigSchema):
 
     enable: bool = False
     unix_socket: Optional[WritableFilePath] = None
-    log_queries: bool = True
-    log_responses: bool = True
-    log_tcp_rtt: bool = True
+    log_queries: bool = False
+    log_responses: bool = False
+    log_tcp_rtt: bool = False
 
     def _validate(self) -> None:
         if self.enable and self.unix_socket is None: