]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: atomisp: mt9m114: Disable V4L2_CID_3A_LOCK control
authorHans de Goede <hdegoede@redhat.com>
Sun, 13 Oct 2024 15:40:54 +0000 (17:40 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 7 Nov 2024 14:16:06 +0000 (15:16 +0100)
The V4L2_CID_3A_LOCK control is causing v4l2_ctrl_new_custom()
to fail with -ERANGE.

It would be better to fix this control but this entire driver is going to
be replaced with the drivers/media/i2c/mt9m114 standard v4l2 driver. This
quick fix gets things going for now until the driver is replaced.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20241013154056.12532-3-hdegoede@redhat.com
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c

index 918ea4fa9f6beb2b7dd077994aee4289ee73f692..b0b740dd3ca3ed3d8d8e72e199038a36f9715f87 100644 (file)
@@ -1224,6 +1224,7 @@ static struct v4l2_ctrl_config mt9m114_controls[] = {
                .def = 0,
                .flags = 0,
        },
+#if 0 /* Causes v4l2_ctrl_new_custom() to fail with -ERANGE, disable for now */
        {
                .ops = &ctrl_ops,
                .id = V4L2_CID_3A_LOCK,
@@ -1235,6 +1236,7 @@ static struct v4l2_ctrl_config mt9m114_controls[] = {
                .def = 0,
                .flags = 0,
        },
+#endif
 };
 
 static int mt9m114_detect(struct mt9m114_device *dev, struct i2c_client *client)