]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-41939: Fix test_site.test_license_exists_at_url() (GH-22559) (#22567)
authorMiss Skeleton (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 5 Oct 2020 16:49:41 +0000 (09:49 -0700)
committerGitHub <noreply@github.com>
Mon, 5 Oct 2020 16:49:41 +0000 (18:49 +0200)
Call urllib.request.urlcleanup() to reset the global
urllib.request._opener.
(cherry picked from commit 1fce240d6c4b2b2cc17a86e88c65169e15b9feeb)

Co-authored-by: Victor Stinner <vstinner@python.org>
Lib/test/test_site.py
Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst [new file with mode: 0644]

index 923f35efe2ede6a36162b7007a6838b8b2156902..ece6a0728063472df2506a2d6a00855e08db1a18 100644 (file)
@@ -509,6 +509,8 @@ class ImportSideEffectTests(unittest.TestCase):
         # string displayed by license in the absence of a LICENSE file.
         url = license._Printer__data.split()[1]
         req = urllib.request.Request(url, method='HEAD')
+        # Reset global urllib.request._opener
+        self.addCleanup(urllib.request.urlcleanup)
         try:
             with socket_helper.transient_internet(url):
                 with urllib.request.urlopen(req) as data:
diff --git a/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst b/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst
new file mode 100644 (file)
index 0000000..e58ad26
--- /dev/null
@@ -0,0 +1,3 @@
+Fix test_site.test_license_exists_at_url(): call
+``urllib.request.urlcleanup()`` to reset the global
+``urllib.request._opener``. Patch by Victor Stinner.