]> git.ipfire.org Git - thirdparty/dhcp.git/commitdiff
always free dstkey now that it is being reference counted
authorMark Andrews <marka@isc.org>
Thu, 9 Dec 2010 04:12:15 +0000 (04:12 +0000)
committerMark Andrews <marka@isc.org>
Thu, 9 Dec 2010 04:12:15 +0000 (04:12 +0000)
omapip/auth.c

index a9a0a850a5bb2b3383edac528609d0e2d98ad07b..ab00b280851cb56f49f07dab4906a318a2592c52 100644 (file)
@@ -115,13 +115,10 @@ isc_result_t omapi_auth_key_enter (omapi_auth_key_t *a)
        if (status == ISC_R_SUCCESS) {
                status = dns_tsec_create(dhcp_gbl_ctx.mctx, dns_tsectype_tsig,
                                         dstkey, &a->tsec_key);
+               dst_key_free(&dstkey);
        }
-       if (status != ISC_R_SUCCESS) {
-               if (dstkey != NULL) {
-                       dst_key_free(&dstkey);
-               }
+       if (status != ISC_R_SUCCESS)
                log_error("Unable to create tsec structure for %s", a->name);
-       }
 
        omapi_auth_key_hash_add (auth_key_hash, a -> name, 0, a, MDL);
        return ISC_R_SUCCESS;