]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] gh-132983: Fix refleak in zstd dictionary functions (gh-134463)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 21 May 2025 19:35:31 +0000 (21:35 +0200)
committerGitHub <noreply@github.com>
Wed, 21 May 2025 19:35:31 +0000 (19:35 +0000)
(cherry picked from commit fb68776591485, AKA gh-134459)

Co-authored-by: Emma Smith <emma@emmatyping.dev>
Modules/_zstd/_zstdmodule.c

index b2e4f95b90635611f433852ce796746374e8d79c..17d3bff1e98769f31e479b2d5c4f839ec2191803 100644 (file)
@@ -251,7 +251,7 @@ _zstd_train_dict_impl(PyObject *module, PyBytesObject *samples_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */
@@ -333,7 +333,7 @@ _zstd_finalize_dict_impl(PyObject *module, PyBytesObject *custom_dict_bytes,
                                             &chunk_sizes);
     if (chunks_number < 0)
     {
-        return NULL;
+        goto error;
     }
 
     /* Allocate dict buffer */