]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: qcom: scm: preserve assign_mem() error return value
authorMukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Thu, 7 Aug 2025 12:44:51 +0000 (18:14 +0530)
committerBjorn Andersson <andersson@kernel.org>
Mon, 11 Aug 2025 15:13:35 +0000 (10:13 -0500)
When qcom_scm_assign_mem() fails, the error value is currently being
overwritten after it is logged, resulting in the loss of the original
error code. Fix this by retaining and returning the original error value
as intended.

Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250807124451.2623019-1-mukesh.ojha@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom/qcom_scm.c

index 26cd0458aacd67dcd36f065675e969cea97eb465..5243d5abbbe9943d3639cf5e5723b738b2d90bdf 100644 (file)
@@ -1119,7 +1119,7 @@ int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz,
        if (ret) {
                dev_err(__scm->dev,
                        "Assign memory protection call failed %d\n", ret);
-               return -EINVAL;
+               return ret;
        }
 
        *srcvm = next_vm;