net: hisilicon: hns_dsaf_mac: fix OF node leak in hns_mac_get_info()

[ Upstream commit 5680cf8d34e1552df987e2f4bb1bff0b2a8c8b11 ]

Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in hns_mac_get_info().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240827144421.52852-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
index 1f44a6463f45b40c787c754cf04307f3c8dfb790..5929ac50e35178b8bd0cd81a6ceda4319bbba75f 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
@@ -933,6 +933,7 @@ static int hns_mac_get_info(struct hns_mac_cb *mac_cb)
                        mac_cb->cpld_ctrl = NULL;
                } else {
                        syscon = syscon_node_to_regmap(cpld_args.np);
+                       of_node_put(cpld_args.np);
                        if (IS_ERR_OR_NULL(syscon)) {
                                dev_dbg(mac_cb->dev, "no cpld-syscon found!\n");
                                mac_cb->cpld_ctrl = NULL;