]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xfs: check the return value of sb_min_blocksize() in xfs_fs_fill_super
authorYongpeng Yang <yangyongpeng@xiaomi.com>
Tue, 4 Nov 2025 12:50:09 +0000 (20:50 +0800)
committerChristian Brauner <brauner@kernel.org>
Wed, 5 Nov 2025 13:00:16 +0000 (14:00 +0100)
sb_min_blocksize() may return 0. Check its return value to avoid the
filesystem super block when sb->s_blocksize is 0.

Cc: stable@vger.kernel.org # v6.15
Fixes: a64e5a596067bd ("bdev: add back PAGE_SIZE block size validation for sb_set_blocksize()")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Yongpeng Yang <yangyongpeng@xiaomi.com>
Link: https://patch.msgid.link/20251104125009.2111925-5-yangyongpeng.storage@gmail.com
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/xfs/xfs_super.c

index e85a156dc17d162decc7c010a74496cb44d38d36..fbb8009f1c0fc496ec94e0fd8b09e040a0c1c293 100644 (file)
@@ -1662,7 +1662,10 @@ xfs_fs_fill_super(
        if (error)
                return error;
 
-       sb_min_blocksize(sb, BBSIZE);
+       if (!sb_min_blocksize(sb, BBSIZE)) {
+               xfs_err(mp, "unable to set blocksize");
+               return -EINVAL;
+       }
        sb->s_xattr = xfs_xattr_handlers;
        sb->s_export_op = &xfs_export_operations;
 #ifdef CONFIG_XFS_QUOTA