]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Initialize struct netr_LogonSamLogonEx
authorAndreas Schneider <asn@samba.org>
Wed, 17 Jul 2024 08:55:28 +0000 (10:55 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 18 Jul 2024 12:47:30 +0000 (12:47 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/rpc/schannel.c:49: var_decl: Declaring variable ""r"" without initializer.
samba-4.20.0rc2/source4/torture/rpc/schannel.c:152: uninit_use_in_call: Using uninitialized value ""r.in.validation_level"" when calling ""torture_comment"".
  150|    ""LogonSamLogonEx failed"");
  151|    } else {
  152|->  torture_comment(tctx,
  153|    ""Skip auth_level[%u] Testing LogonSamLogonEx with name %s using %s and validation_level: %d\n"",
  154|    auth_level, ninfo.identity_info.account_name.string, crypto_alg,"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
source4/torture/rpc/schannel.c

index 04752424cd2545ae6cc00c327c35f0076444261a..fab1fa4af4550b1c7d3ce456a1d9225d70da0b05 100644 (file)
@@ -46,7 +46,7 @@ bool test_netlogon_ex_ops(struct dcerpc_pipe *p, struct torture_context *tctx,
                          struct netlogon_creds_CredentialState *creds)
 {
        NTSTATUS status;
-       struct netr_LogonSamLogonEx r;
+       struct netr_LogonSamLogonEx r = {};
        struct netr_NetworkInfo ninfo;
        union netr_LogonLevel logon;
        union netr_Validation validation;