]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/sun4i: Fix resource leaks
authorEthan Tidmore <ethantidmore06@gmail.com>
Thu, 26 Feb 2026 16:38:36 +0000 (10:38 -0600)
committerChen-Yu Tsai <wens@kernel.org>
Sat, 14 Mar 2026 08:07:52 +0000 (16:07 +0800)
Three clocks are not being released in devm_regmap_init_mmio() error
path.

Add proper goto and set ret to the error code.

Fixes: 8270249fbeaf0 ("drm/sun4i: backend: Create regmap after access is possible")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://patch.msgid.link/20260226163836.10335-1-ethantidmore06@gmail.com
Signed-off-by: Chen-Yu Tsai <wens@kernel.org>
drivers/gpu/drm/sun4i/sun4i_backend.c

index 6391bdc94a5c2aa612cb15eec3015be0aafbe416..e989f75c09b7dabc703d47ea4bc113bdbd9bde01 100644 (file)
@@ -881,7 +881,8 @@ static int sun4i_backend_bind(struct device *dev, struct device *master,
                                                     &sun4i_backend_regmap_config);
        if (IS_ERR(backend->engine.regs)) {
                dev_err(dev, "Couldn't create the backend regmap\n");
-               return PTR_ERR(backend->engine.regs);
+               ret = PTR_ERR(backend->engine.regs);
+               goto err_disable_ram_clk;
        }
 
        list_add_tail(&backend->engine.list, &drv->engine_list);