]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low
authorJohan Hovold <johan@kernel.org>
Mon, 26 Jan 2015 11:02:46 +0000 (12:02 +0100)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 10 Feb 2015 13:38:45 +0000 (13:38 +0000)
commit 49d2ca84e433dab854c7a866bc6add09cfab682d upstream.

Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when setting the
gpio-line polarity.

Fixes: 0769746183ca ("gpiolib: add support for changing value polarity
in sysfs")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
[ luis: backported to 3.16:
  - file rename: drivers/gpio/gpiolib-sysfs.c -> drivers/gpio/gpiolib.c ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/gpio/gpiolib.c

index 69fc2fcfc3e98896c4d88c84e6503fe2648b5436..afdca5a6b2a6c4613511ecc867a8bde58d6364fb 100644 (file)
@@ -960,6 +960,7 @@ int gpiod_sysfs_set_active_low(struct gpio_desc *desc, int value)
 
        status = sysfs_set_active_low(desc, dev, value);
 
+       put_device(dev);
 unlock:
        mutex_unlock(&sysfs_lock);