]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: check for all errors in test-reread-partition-table
authorLuca Boccassi <luca.boccassi@gmail.com>
Fri, 21 Nov 2025 17:53:46 +0000 (17:53 +0000)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 21 Nov 2025 18:13:39 +0000 (19:13 +0100)
Otherwise if opening the loop dev fails, the test segfaults
dereferencing a NULL variable later

Follow-up for 757887d01dd96125be1774f4b23b12f2fbda9a8b

src/test/test-reread-partition-table.c

index 5f465e61db2c6eb09e82e934119af49e22153000..cff31f41a1e9442866cadc02eb375c6dc2fbca13 100644 (file)
@@ -70,6 +70,8 @@ TEST(rereadpt) {
                         LOCK_EX, &loop);
         if (ERRNO_IS_NEG_PRIVILEGE(r) || ERRNO_IS_NOT_SUPPORTED(r))
                 return (void) log_tests_skipped("loopback block devices not available");
+        if (r < 0)
+                return (void) log_error_errno(r, "Failed to create loop device: %m");
 
         _cleanup_free_ char *p = NULL;
         ASSERT_OK(partition_node_of(loop->node, 1, &p));