]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
serial: stm32: Reset .throttled state in .startup()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 17 Apr 2024 09:03:28 +0000 (11:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 27 Apr 2024 15:11:39 +0000 (17:11 +0200)
commit ea2624b5b829b8f93c0dce25721d835969b34faf upstream.

When an UART is opened that still has .throttled set from a previous
open, the RX interrupt is enabled but the irq handler doesn't consider
it. This easily results in a stuck irq with the effect to occupy the CPU
in a tight loop.

So reset the throttle state in .startup() to ensure that RX irqs are
handled.

Fixes: d1ec8a2eabe9 ("serial: stm32: update throttle and unthrottle ops for dma mode")
Cc: stable@vger.kernel.org
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/a784f80d3414f7db723b2ec66efc56e1ad666cbf.1713344161.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/stm32-usart.c

index 90f83e6fc592ae8b8d035010d91c6a14f4bb3825..9ef90bb30a47ebec338d4bf0b02e5fe6a5be8c63 100644 (file)
@@ -1077,6 +1077,7 @@ static int stm32_usart_startup(struct uart_port *port)
                val |= USART_CR2_SWAP;
                writel_relaxed(val, port->membase + ofs->cr2);
        }
+       stm32_port->throttled = false;
 
        /* RX FIFO Flush */
        if (ofs->rqr != UNDEF_REG)