Disable DirPort when BridgeRelay is set

diff --git a/changes/bug2060 b/changes/bug2060
new file mode 100644 (file)
index 0000000..eb95aed
--- /dev/null
+++ b/changes/bug2060
@@ -0,0 +1,4 @@
+  o Minor features
+    - Make sure to disable DirPort if running as a bridge.  DirPorts aren't
+      used on bridges, and it makes bridge scanning way too easy.
+

diff --git a/src/or/config.c b/src/or/config.c
index e3d5e606f90cc97994014d192c0b7ff251ba6822..bd8c45758b709a917cc5279fd8bd242af4c0b07b 100644 (file)
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -3281,6 +3281,12 @@ options_validate(or_options_t *old_options, or_options_t *options,
            "PublishServerDescriptor line.");
   }
 
+  if (options->BridgeRelay && options->DirPort) {
+    log_warn(LD_CONFIG, "Can't set a DirPort on a bridge relay; disabling "
+             "DirPort");
+    options->DirPort = 0;
+  }
+
   if (options->MinUptimeHidServDirectoryV2 < 0) {
     log_warn(LD_CONFIG, "MinUptimeHidServDirectoryV2 option must be at "
                         "least 0 seconds. Changing to 0.");