]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: xilinx-ams: Fix AMS_ALARM_THR_DIRECT_MASK
authorSean Anderson <sean.anderson@linux.dev>
Tue, 15 Jul 2025 00:30:58 +0000 (20:30 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 25 Aug 2025 11:22:52 +0000 (12:22 +0100)
AMS_ALARM_THR_DIRECT_MASK should be bit 0, not bit 1. This would cause
hysteresis to be enabled with a lower threshold of -28C. The temperature
alarm would never deassert even if the temperature dropped below the
upper threshold.

Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: O'Griofa, Conall <conall.ogriofa@amd.com>
Tested-by: Erim, Salih <Salih.Erim@amd.com>
Acked-by: Erim, Salih <Salih.Erim@amd.com>
Link: https://patch.msgid.link/20250715003058.2035656-1-sean.anderson@linux.dev
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/xilinx-ams.c

index 180d4140993d9f22801b0db681fe2f0348e13c18..124470c92529782db85590ea8c632e2419460c08 100644 (file)
 #define AMS_ALARM_THRESHOLD_OFF_10     0x10
 #define AMS_ALARM_THRESHOLD_OFF_20     0x20
 
-#define AMS_ALARM_THR_DIRECT_MASK      BIT(1)
+#define AMS_ALARM_THR_DIRECT_MASK      BIT(0)
 #define AMS_ALARM_THR_MIN              0x0000
 #define AMS_ALARM_THR_MAX              (BIT(16) - 1)