]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core: double free in bus_timer_set_transient_property
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 4 Jan 2018 10:19:55 +0000 (11:19 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 4 Jan 2018 10:31:37 +0000 (11:31 +0100)
Introduced in 3e3c5a4571d. CID #1384233.

src/core/dbus-timer.c

index 900ed369ddd75c4bb840eea3cee5ddc5360d1e92..1eedf217fe2c8b7d60ccc3d3a4a637be1392342d 100644 (file)
@@ -373,10 +373,8 @@ static int bus_timer_set_transient_property(
                         unit_write_settingf(u, flags|UNIT_ESCAPE_SPECIFIERS, name, "%s=%s", name, str);
 
                         v = new0(TimerValue, 1);
-                        if (!v) {
-                                calendar_spec_free(c);
+                        if (!v)
                                 return -ENOMEM;
-                        }
 
                         v->base = TIMER_CALENDAR;
                         v->calendar_spec = c;