]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.12] gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 9 Oct 2023 11:42:04 +0000 (13:42 +0200)
committerGitHub <noreply@github.com>
Mon, 9 Oct 2023 11:42:04 +0000 (11:42 +0000)
gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of DLLs to bundle (GH-110470)
(cherry picked from commit 12cc6792d0ca1d0b72712d77c6efcb0aa0c7e7ba)

Co-authored-by: Steve Dower <steve.dower@python.org>
Misc/NEWS.d/next/Windows/2023-10-06-14-20-14.gh-issue-110437.xpYy9q.rst [new file with mode: 0644]
PCbuild/pyproject.props

diff --git a/Misc/NEWS.d/next/Windows/2023-10-06-14-20-14.gh-issue-110437.xpYy9q.rst b/Misc/NEWS.d/next/Windows/2023-10-06-14-20-14.gh-issue-110437.xpYy9q.rst
new file mode 100644 (file)
index 0000000..777b494
--- /dev/null
@@ -0,0 +1,2 @@
+Allows overriding the source of VC redistributables so that releases can be
+guaranteed to never downgrade between updates.
index fd928cafd77aaadf6c2fd0757dc01b0545521406..056ab2b3b6643a0579a6b472360669d2ef52f2ab 100644 (file)
@@ -232,7 +232,10 @@ public override bool Execute() {
   </Target>
 
   <Target Name="FindVCRuntime" Returns="VCRuntimeDLL" DependsOnTargets="FindVCRedistDir">
-    <ItemGroup Condition="$(VCInstallDir) != ''">
+    <ItemGroup Condition="$(VCRuntimeDLL) != ''">
+      <VCRuntimeDLL Include="$(VCRuntimeDLL)" />
+    </ItemGroup>
+    <ItemGroup Condition="$(VCInstallDir) != '' and $(VCRuntimeDLL) == ''">
       <VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" />
     </ItemGroup>