clean up pointers on clone

and only free in the master

diff --git a/src/modules/proto_radius/proto_radius_udp.c b/src/modules/proto_radius/proto_radius_udp.c
index 641123f7f90597023420f22ce2d9549c249a76a0..7d901f2161e10486e0690a4e6b155276d5a0e430 100644 (file)
--- a/src/modules/proto_radius/proto_radius_udp.c
+++ b/src/modules/proto_radius/proto_radius_udp.c
@@ -740,6 +740,10 @@ static proto_radius_udp_t *mod_clone(proto_radius_udp_t *inst, proto_radius_udp_
        child->child.src_ipaddr = address->src_ipaddr;
        child->child.src_port = address->src_port;
 
+       child->dynamic_clients.clients = NULL;
+       child->dynamic_clients.expired = NULL;
+       child->dynamic_clients.trie = NULL;
+
        child->child.client = client_clone(child, address->client);
        if (!child->child.client) {
                ERROR("Failed cloning client");
@@ -2073,8 +2077,6 @@ static int mod_detach(void *instance)
 
        close(inst->sockfd);
 
-       if (inst->dynamic_clients.clients) TALLOC_FREE(inst->dynamic_clients.clients);
-
        /*
         *      Clean up extra tracking information when using
         *      connected sockets.
@@ -2105,6 +2107,12 @@ static int mod_detach(void *instance)
                }
        }
 
+       if (inst->dynamic_clients_is_set) {
+               TALLOC_FREE(inst->dynamic_clients.clients);
+               TALLOC_FREE(inst->dynamic_clients.expired);
+               TALLOC_FREE(inst->dynamic_clients.trie);
+       }
+
        return 0;
 }