activation: Don't leak if delivering activation message is forbidden

This is technically a denial of service because the dbus-daemon will
run out of memory eventually, but it's a very slow and noisy one,
because all the rejected messages are also very likely to have
been logged to the system log.

Detected by AddressSanitizer.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: https://gitlab.freedesktop.org/dbus/dbus/issues/234
Reviewed-by: pwithnall

diff --git a/bus/activation.c b/bus/activation.c
index 706707ce182b3691e2bf1d100ee7a156a8c29e6f..2c5d710fc0e7e6b2dbe0bc99913b12659fee2340 100644 (file)
--- a/bus/activation.c
+++ b/bus/activation.c
@@ -1299,6 +1299,7 @@ bus_activation_send_pending_auto_activation_messages (BusActivation  *activation
                                                  entry->activation_message);
                 }
 
+              dbus_error_free (&error);
               link = next;
               continue;
             }