]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2136] Fixed unfinished MockAuth objects
authorNaoki Kambe <kambe@jprs.co.jp>
Fri, 27 Jul 2012 01:16:51 +0000 (10:16 +0900)
committerNaoki Kambe <kambe@jprs.co.jp>
Wed, 8 Aug 2012 12:06:28 +0000 (21:06 +0900)
The extra MockAuth objects didn't shut down in
BaseModules.shutdown(). But these weren't needed for unittest of stats
httpd. So setting up and shutting up of them were moved to
b10-stats_test.py from test_utils.py.

src/bin/stats/tests/b10-stats_test.py
src/bin/stats/tests/test_utils.py

index 68cf48053370d62f5e1d329ec872cc1086c6a9ea..bb820699d4e24e79924d17d516740d292b38c8ec 100644 (file)
@@ -30,7 +30,7 @@ import imp
 
 import stats
 import isc.cc.session
-from test_utils import BaseModules, ThreadingServerManager, MyStats, SignalHandler, send_command, send_shutdown
+from test_utils import BaseModules, ThreadingServerManager, MyStats, SignalHandler, send_command, send_shutdown, MockAuth
 from isc.testutils.ccsession_mock import MockModuleCCSession
 
 class TestUtilties(unittest.TestCase):
@@ -150,11 +150,19 @@ class TestStats(unittest.TestCase):
         # set the signal handler for deadlock
         self.sig_handler = SignalHandler(self.fail)
         self.base = BaseModules()
+        # invoke more three MockAuth
+        for i in ['2', '3', '4']:
+            setattr(self.base, "auth"+i, \
+                        ThreadingServerManager(MockAuth))
+            getattr(self.base, "auth"+i).run()
         self.const_timestamp = 1308730448.965706
         self.const_datetime = '2011-06-22T08:14:08Z'
         self.const_default_datetime = '1970-01-01T00:00:00Z'
 
     def tearDown(self):
+        # shutdown more three MockAuth
+        for i in ['2', '3', '4']:
+            getattr(self.base, "auth"+i).shutdown()
         self.base.shutdown()
         # reset the signal handler
         self.sig_handler.reset()
index fcb7fc4bce3fad898f27feec63533416e38c89db..7d3f5396bda1a09e0694edf776a3b28160824ea2 100644 (file)
@@ -474,11 +474,9 @@ class BaseModules:
         # MockBoss
         self.boss = ThreadingServerManager(MockBoss)
         self.boss.run()
-        # MockAuth * 4
-        for i in ['', '2', '3', '4']:
-            setattr(self,"auth"+i, \
-                        ThreadingServerManager(MockAuth))
-            getattr(self, "auth"+i).run()
+        # MockAuth
+        self.auth = ThreadingServerManager(MockAuth)
+        self.auth.run()
 
     def shutdown(self):
         # MockAuth