repart: Always derive fs/luks UUIDs from generated partition UUID

When generating verity partitions, we only know the partition UUID
of the verity data and hash partition after doing the verity
formatting. This means we can't use the verity partition UUID as
input for deriving the filesystem/luks UUIDs. Currently, we derive
the filesystem/luks UUID from the null UUID instead, which isn't
ideal. Instead, let's always generate a partition UUID and use it
to derive the fs/luks UUIDs, but only use it as the actual partition
UUID if we're not doing verity for the partition.

diff --git a/src/partition/repart.c b/src/partition/repart.c
index 80cd7daba321db5d34394c3d7576123c826ce60b..64a3637369cbdb893df2bcc2346f536d55a7ec7b 100644 (file)
--- a/src/partition/repart.c
+++ b/src/partition/repart.c
@@ -194,7 +194,7 @@ typedef struct Partition {
         sd_id128_t current_uuid, new_uuid;
         bool new_uuid_is_set;
         char *current_label, *new_label;
-        sd_id128_t fs_uuid;
+        sd_id128_t fs_uuid, luks_uuid;
 
         bool dropped;
         bool factory_reset;
@@ -3236,7 +3236,6 @@ static int partition_encrypt(Context *context, Partition *p, const char *node) {
         _cleanup_free_ char *hp = NULL;
         const char *passphrase = NULL;
         size_t passphrase_size = 0;
-        sd_id128_t uuid;
         const char *vt;
         int r;
 
@@ -3248,10 +3247,6 @@ static int partition_encrypt(Context *context, Partition *p, const char *node) {
         if (r < 0)
                 return log_error_errno(r, "libcryptsetup not found, cannot encrypt: %m");
 
-        r = derive_uuid(p->new_uuid, "luks-uuid", &uuid);
-        if (r < 0)
-                return r;
-
         log_info("Encrypting future partition %" PRIu64 "...", p->partno);
 
         r = var_tmp_dir(&vt);
@@ -3292,7 +3287,7 @@ static int partition_encrypt(Context *context, Partition *p, const char *node) {
                          CRYPT_LUKS2,
                          "aes",
                          "xts-plain64",
-                         SD_ID128_TO_UUID_STRING(uuid),
+                         SD_ID128_TO_UUID_STRING(p->luks_uuid),
                          NULL,
                          VOLUME_KEY_SIZE,
                          &luks_params);
@@ -4271,6 +4266,8 @@ static int context_acquire_partition_uuids_and_labels(Context *context) {
         assert(context);
 
         LIST_FOREACH(partitions, p, context->partitions) {
+                sd_id128_t uuid;
+
                 /* Never touch foreign partitions */
                 if (PARTITION_IS_FOREIGN(p)) {
                         p->new_uuid = p->current_uuid;
@@ -4285,22 +4282,38 @@ static int context_acquire_partition_uuids_and_labels(Context *context) {
                 }
 
                 if (!sd_id128_is_null(p->current_uuid))
-                        p->new_uuid = p->current_uuid; /* Never change initialized UUIDs */
-                else if (!p->new_uuid_is_set && !IN_SET(p->verity, VERITY_DATA, VERITY_HASH)) {
+                        p->new_uuid = uuid = p->current_uuid; /* Never change initialized UUIDs */
+                else if (p->new_uuid_is_set)
+                        uuid = p->new_uuid;
+                else {
                         /* Not explicitly set by user! */
-                        r = partition_acquire_uuid(context, p, &p->new_uuid);
+                        r = partition_acquire_uuid(context, p, &uuid);
                         if (r < 0)
                                 return r;
 
-                        p->new_uuid_is_set = true;
+                        /* The final verity hash/data UUIDs can only be determined after formatting the
+                         * verity hash partition. However, we still want to use the generated partition UUID
+                         * to derive other UUIDs to keep things unique and reproducible, so we always
+                         * generate a UUID if none is set, but we only use it as the actual partition UUID if
+                         * verity is not configured. */
+                        if (!IN_SET(p->verity, VERITY_DATA, VERITY_HASH)) {
+                                p->new_uuid = uuid;
+                                p->new_uuid_is_set = true;
+                        }
                 }
 
                 /* Calculate the UUID for the file system as HMAC-SHA256 of the string "file-system-uuid",
                  * keyed off the partition UUID. */
-                r = derive_uuid(p->new_uuid, "file-system-uuid", &p->fs_uuid);
+                r = derive_uuid(uuid, "file-system-uuid", &p->fs_uuid);
                 if (r < 0)
                         return r;
 
+                if (p->encrypt != ENCRYPT_OFF) {
+                        r = derive_uuid(uuid, "luks-uuid", &p->luks_uuid);
+                        if (r < 0)
+                                return r;
+                }
+
                 if (!isempty(p->current_label)) {
                         /* never change initialized labels */
                         r = free_and_strdup_warn(&p->new_label, p->current_label);