]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
can: kvaser_usb: fix return value for hif_usb_send_regout
authorChen Ni <nichen@iscas.ac.cn>
Tue, 21 May 2024 04:10:20 +0000 (12:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 27 Jul 2024 08:38:31 +0000 (10:38 +0200)
[ Upstream commit 0d34d8163fd87978a6abd792e2d8ad849f4c3d57 ]

As the potential failure of usb_submit_urb(), it should be better to
return the err variable to catch the error.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://lore.kernel.org/all/20240521041020.1519416-1-nichen@iscas.ac.cn
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c

index 411b3adb1d9ea6e2ea1116dbeb2b0cea7b672be7..a96b2239840705114d2f581f68f689c3ed7b0058 100644 (file)
@@ -266,7 +266,7 @@ int kvaser_usb_send_cmd_async(struct kvaser_usb_net_priv *priv, void *cmd,
        }
        usb_free_urb(urb);
 
-       return 0;
+       return err;
 }
 
 int kvaser_usb_can_rx_over_error(struct net_device *netdev)