]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: dwc3: omap: add missing depopulate in probe error path
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 16 Aug 2024 07:54:08 +0000 (09:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Sep 2024 11:17:47 +0000 (13:17 +0200)
commit 2aa765a43817ec8add990f83c8e54a9a5d87aa9c upstream.

Depopulate device in probe error paths to fix leak of children
resources.

Fixes: ee249b455494 ("usb: dwc3: omap: remove IRQ_NOAUTOEN used with shared irq")
Cc: stable@vger.kernel.org
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Link: https://lore.kernel.org/r/20240816075409.23080-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-omap.c

index efaf0db595f4619ae4f32237967963626c4ca44b..6b59bbb22da49b4ec42af5b2a741853a504ee6c4 100644 (file)
@@ -522,11 +522,13 @@ static int dwc3_omap_probe(struct platform_device *pdev)
        if (ret) {
                dev_err(dev, "failed to request IRQ #%d --> %d\n",
                        omap->irq, ret);
-               goto err1;
+               goto err2;
        }
        dwc3_omap_enable_irqs(omap);
        return 0;
 
+err2:
+       of_platform_depopulate(dev);
 err1:
        pm_runtime_put_sync(dev);
        pm_runtime_disable(dev);