]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-44469: Fix tests for "async with" with bad object (GH-26817)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 21 Jun 2021 07:54:04 +0000 (00:54 -0700)
committerGitHub <noreply@github.com>
Mon, 21 Jun 2021 07:54:04 +0000 (00:54 -0700)
Test for execution of the body was null. It would pass
even if the code which should be skipped was executed.
(cherry picked from commit 5d2b3a0d688cf8a33db3d266c9e7049c13766a4c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Lib/test/test_coroutines.py

index 8d1e0692a24221bf024b061cebfff9fe9144ecfd..1e01e3be83cda1e84ac31ab8ece9ccaeea684881 100644 (file)
@@ -1203,41 +1203,47 @@ class CoroutineTest(unittest.TestCase):
             def __aenter__(self):
                 pass
 
-        body_executed = False
+        body_executed = None
         async def foo():
+            nonlocal body_executed
+            body_executed = False
             async with CM():
                 body_executed = True
 
         with self.assertRaisesRegex(AttributeError, '__aexit__'):
             run_async(foo())
-        self.assertFalse(body_executed)
+        self.assertIs(body_executed, False)
 
     def test_with_3(self):
         class CM:
             def __aexit__(self):
                 pass
 
-        body_executed = False
+        body_executed = None
         async def foo():
+            nonlocal body_executed
+            body_executed = False
             async with CM():
                 body_executed = True
 
         with self.assertRaisesRegex(AttributeError, '__aenter__'):
             run_async(foo())
-        self.assertFalse(body_executed)
+        self.assertIs(body_executed, False)
 
     def test_with_4(self):
         class CM:
             pass
 
-        body_executed = False
+        body_executed = None
         async def foo():
+            nonlocal body_executed
+            body_executed = False
             async with CM():
                 body_executed = True
 
         with self.assertRaisesRegex(AttributeError, '__aenter__'):
             run_async(foo())
-        self.assertFalse(body_executed)
+        self.assertIs(body_executed, False)
 
     def test_with_5(self):
         # While this test doesn't make a lot of sense,